Handle new mongot config schema #230
Merged
+394
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsierant
force-pushed
the
lsierant/search-config-schema
branch
3 times, most recently
from
9906c42 to
4cc828f
Compare
anandsyncs
reviewed
Jul 11, 2025
| Enabled: true, | ||
| Address: fmt.Sprintf("localhost:%d", search.GetMongotMetricsPort()), | ||
| }, | ||
| Logging: mongot.Logging{ | ||
| HealthCheck: mongot.ConfigHealthCheck{ | ||
| Address: "0.0.0.0:8080", |
There was a problem hiding this comment.
Do we need to read from a config?
There was a problem hiding this comment.
I don't think so, we know in the operator what we're setting here, so the readiness probe can be configured accordingly.
lsierant
force-pushed
the
lsierant/search-config-schema
branch
from
4cc828f to
90b7a37
Compare
|
evergreen refresh |
lsierant
commented
Jul 16, 2025
|
|
||
| if ! /mongot-community/mongot --config /mongot/config/config.yml; then | ||
| echo "mongot error code, sleeping to allow to ssh" | ||
| sleep 600 |
There was a problem hiding this comment.
this is temporary, to be removed before merging
lsierant
force-pushed
the
lsierant/search-config-schema
branch
from
25205fa to
6b79a6f
Compare
lsierant
force-pushed
the
lsierant/search-config-schema
branch
from
6b79a6f to
f438d3e
Compare
lsierant
requested review from
m1kola and
viveksinghggits
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements minimum necessary changes to run against newest mongot container built from master: